hm/ViewDesignEngine

Fork 0

Files

T

茂之钳 93ca49cb4f

CI / Build & Test (push) Failing after 16m56s

Details

CI / Release Build (push) Failing after 30s

Details

Build & Test / build-and-test (push) Has been cancelled

Details

Build & Test / python-bindings (push) Has been cancelled

Details

fix: VDE-028~030 compile warnings — close all ViewDesign feedback issues

VDE-028 (step_export.cpp):
  - Remove unused
  - Fix 4x misleading-indentation in write_bspline_surface loops

VDE-029 (class_a_surfacing.cpp):
  - Initialize Vector3D move = Vector3D::Zero() (2 occurrences)

VDE-030 (industrial_formats.cpp):
  - Remove unused brep_version read, fix pos_ offset
  - Fix misleading-indentation: split one-liner if-statements

All 30 VDE issues now resolved (30/30).

2026-07-28 21:24:27 +08:00

1.2 KiB

Raw Blame History

id, status, severity, category, date, reporter

id	status	severity	category	date	reporter
VDE-028	fixed	low	code-quality	2026-07-28	ViewDesign

VDE-028: step_export.cpp 误导缩进警告 + 未使用变量

描述

在 ViewDesign MSVC 构建中，vde_brep 的 step_export.cpp 产生多个编译警告：

-Wmisleading-indentation (4处)：write_bspline_surface 函数中 if 语句和后续语句在同一行，误导缩进
- 行 276: if (i > 0) ss << ","; ss << um[i];
- 行 280: if (i > 0) ss << ","; ss << vm[i];
- 行 284: if (i > 0) ss << ","; ss << uu[i];
- 行 288: if (i > 0) ss << ","; ss << vuu[i];
-Wunused-variable (1处)：行 233 auto& w = surf.weights(); 声明后未使用

复现步骤

cmake --build build --config Release --target vde_brep

影响

仅影响代码整洁度，不影响功能正确性
大量警告可能掩盖真正的错误

修复建议

误导缩进：将同一行的两个语句拆分为多行带大括号

if (i > 0) { ss << ","; }
ss << um[i];

未使用变量：删除 auto& w = surf.weights();，或添加 (void)w;

1.2 KiB Raw Blame History Unescape Escape

VDE-028: step_export.cpp 误导缩进警告 + 未使用变量

描述

复现步骤

影响

修复建议

相关文件

1.2 KiB

Raw Blame History