Files
ViewDesignEngine/docs/feedback/VDE-029.md
T
茂之钳 93ca49cb4f
Build & Test / build-and-test (push) Waiting to run
Build & Test / python-bindings (push) Blocked by required conditions
CI / Build & Test (push) Failing after 16m56s
CI / Release Build (push) Failing after 30s
fix: VDE-028~030 compile warnings — close all ViewDesign feedback issues
VDE-028 (step_export.cpp):
  - Remove unused
  - Fix 4x misleading-indentation in write_bspline_surface loops

VDE-029 (class_a_surfacing.cpp):
  - Initialize Vector3D move = Vector3D::Zero() (2 occurrences)

VDE-030 (industrial_formats.cpp):
  - Remove unused brep_version read, fix pos_ offset
  - Fix misleading-indentation: split one-liner if-statements

All 30 VDE issues now resolved (30/30).
2026-07-28 21:24:27 +08:00

892 B

id, status, severity, category, date, reporter
id status severity category date reporter
VDE-029 fixed low code-quality 2026-07-28 ViewDesign

VDE-029: class_a_surfacing.cpp move 变量可能未初始化

描述

在 ViewDesign MSVC 构建中,vde_curvesclass_a_surfacing.cpp 产生 -Wmaybe-uninitialized 警告:

  • 行 1443: Vector3D move; 声明但未被初始化
  • 行 1445: 在 curvature_continuity_optimization 函数中使用 move 参与运算,编译器分析认为该变量部分路径可能未赋值

复现步骤

cmake --build build --config Release --target vde_curves

影响

  • 代码整洁度问题,在实际执行路径中可能已被正确赋值
  • 大量 Eigen 模板内联展开导致警告信息冗长

修复建议

将声明改为带默认初始化:

Vector3D move = Vector3D::Zero();

相关文件

  • src/curves/class_a_surfacing.cpp:1443,1445