Commit Graph

13 Commits

Author SHA1 Message Date
茂之钳 c713f2cdff fix(v1.0.1): resolve VDE-016 and VDE-017 — GCC compilation fixes from ViewDesign feedback
CI / Build & Test (push) Failing after 33s
CI / Release Build (push) Failing after 34s
Build & Test / build-and-test (push) Has been cancelled
Build & Test / python-bindings (push) Has been cancelled
VDE-016 (ssi_boolean.cpp): Moved SSICurveData out of anonymous namespace
  into explicit vde::brep, added #include <iterator> for std::begin/end,
  added using ClassResult. Fixes GCC two-phase name lookup failures.

VDE-017 (CMakeLists.txt): Changed CMAKE_SOURCE_DIR to
  CMAKE_CURRENT_SOURCE_DIR in configure_file call so VDE builds
  correctly as a submodule.

Both fixes were already applied in main; this commit records the
updated issue status from the feedback branch.
2026-07-28 09:45:05 +08:00
茂之钳 514a9a633c fix(v1.0.1): VDE-016 — definitive fix: fully-qualified names throughout
CI / Build & Test (push) Failing after 24s
CI / Release Build (push) Failing after 39s
Build & Test / build-and-test (push) Has been cancelled
Build & Test / python-bindings (push) Has been cancelled
Root cause: GCC two-phase lookup with multiple anonymous namespaces
creates barriers that using declarations cannot cross.

Fix: Replace all unqualified SSICurveData/ClassResult with
vde::brep::SSICurveData/vde::brep::ClassResult throughout the file.
This is the only approach verified to work by ViewDesign.
2026-07-28 08:04:34 +08:00
hm faa20db3c9 docs: update VDE-016 — using declarations are no-ops inside same namespace; only fully-qualified names work
CI / Build & Test (push) Failing after 41s
CI / Release Build (push) Failing after 33s
Build & Test / build-and-test (push) Has been cancelled
Build & Test / python-bindings (push) Has been cancelled
2026-07-28 07:56:02 +08:00
茂之钳 477d13dc80 fix(v1.0.1): VDE-016 — using declarations at vde::brep scope, not inside anonymous ns
CI / Build & Test (push) Failing after 34s
CI / Release Build (push) Failing after 25s
Build & Test / build-and-test (push) Has been cancelled
Build & Test / python-bindings (push) Has been cancelled
Root cause: using declarations inside anonymous namespace don't propagate
to public functions defined after the anonymous namespace closes.

Fix:
- using SSICurveData; and using ClassResult; at vde::brep scope
- Remove self-referencing using vde::brep::ClassResult
- Remove duplicate using from inside anonymous namespace
2026-07-28 07:48:28 +08:00
hm d9963d8e85 docs: update VDE-016 — using declarations must be in vde::brep scope, not inside namespace{}
CI / Build & Test (push) Failing after 28s
CI / Release Build (push) Failing after 40s
Build & Test / build-and-test (push) Has been cancelled
Build & Test / python-bindings (push) Has been cancelled
2026-07-28 07:32:31 +08:00
茂之钳 a10b1ffe3a fix(v1.0.1): VDE-016 — anonymous namespace needs fully-qualified names
CI / Build & Test (push) Failing after 26s
CI / Release Build (push) Failing after 35s
Build & Test / build-and-test (push) Has been cancelled
Build & Test / python-bindings (push) Has been cancelled
Root cause: GCC two-phase lookup requires fully-qualified names
when accessing enclosing namespace types from inside anonymous namespace.
Fix: add using vde::brep::SSICurveData and using vde::brep::ClassResult
inside both anonymous namespaces in ssi_boolean.cpp
2026-07-28 07:17:13 +08:00
hm 006dd3f136 docs: update VDE-016 — v1.0.3 fix insufficient, need fully qualified names
CI / Build & Test (push) Failing after 42s
CI / Release Build (push) Failing after 38s
Build & Test / build-and-test (push) Has been cancelled
Build & Test / python-bindings (push) Has been cancelled
2026-07-28 00:09:51 +08:00
茂之钳 b48ffec290 fix(v1.0.1): VDE-016 root cause + VDE-017 submodule path
CI / Build & Test (push) Failing after 32s
CI / Release Build (push) Failing after 31s
Build & Test / build-and-test (push) Has been cancelled
Build & Test / python-bindings (push) Has been cancelled
VDE-016 (High): GCC two-phase lookup — root cause is anonymous namespace
- Move SSICurveData OUT of anonymous namespace into vde::brep
- Add #include <iterator> for std::begin/end
- Add using vde::brep::ClassResult

VDE-017 (Medium): Root CMakeLists configure_file CMAKE_SOURCE_DIR
- Change to CMAKE_CURRENT_SOURCE_DIR for submodule compatibility
2026-07-27 23:34:18 +08:00
茂之钳 7a955bac7f fix(v1.0.1): VDE-014/015/016 — STL API cleanup + ssi_boolean fixes
CI / Build & Test (push) Failing after 41s
CI / Release Build (push) Failing after 35s
Build & Test / build-and-test (push) Has been cancelled
Build & Test / python-bindings (push) Has been cancelled
VDE-014 (High): Remove duplicate void write_stl/write_stl_ascii declarations
VDE-015 (Medium): Fix Vector3F→Vector3f, Point3F→Point3f case sensitivity
VDE-016 (High): Add forward declarations for face_bounds/face_normal/SSICurveData
  in ssi_boolean.cpp — fixes two-phase name lookup in GCC
2026-07-27 23:20:46 +08:00
hm 41d33bbbc2 docs: add VDE-014/015/016 + update overview (7 fixed, 3 new, 1 P0 remaining)
CI / Build & Test (push) Failing after 16m55s
CI / Release Build (push) Failing after 33s
Build & Test / build-and-test (push) Has been cancelled
Build & Test / python-bindings (push) Has been cancelled
2026-07-27 23:12:30 +08:00
茂之钳 5de74b543a docs: mark all 13 VDE issues as fixed
VDE-001 through VDE-013 all resolved in v1.0.1
ViewDesign workarounds can now be removed
2026-07-27 22:56:29 +08:00
hm a5594c293b docs: add overall VDE integration assessment from ViewDesign 2026-07-27 22:31:16 +08:00
hm 5eb11fa501 docs: feedback from ViewDesign integration (VDE-001~013) 2026-07-27 22:13:00 +08:00